Re: [PATCH v6 1/3] vimdiff: new implementation with layout support
- From
Fernando Ramos <greenfoo@u92.eu>
- Date
- Mar 27, 2022, 18:12 UTC
- Message-ID
- <YkCpCJfX/xdp+P7r@zacax395.localdomain>
- In-Reply-To
- <00463195-5514-bf2b-e733-24e1e24a70cb@gmail.com>
Show 8 quoted lines
> > +################################################################################
> > +## Internal functions (not meant to be used outside this script)
> > +################################################################################
> > +
> > +debug_print () {
> > + # Send message to stderr if global variable DEBUG is set to "true"
>
> This should also be GIT_MERGETOOL_VIMDIFF_DEBUG, right?Good catch! I'll fix it in v7.
Show 13 quoted lines
> > +gen_cmd () {
> > + # This function returns (in global variable FINAL_CMD) the string that
> > + # you can use when invoking "vim" (as shown next) to obtain a given
> > + # layout:
> > + #
> > + # $ vim -f $FINAL_CMD "$LOCAL" "$BASE" "$REMOTE" "$MERGED"
> > + #
> > + # It takes one single argument: a string containing the desired layout
> > + # definition.
> > + #
> > + # The syntax of the "layout definitions" is explained in ... (TODO)...
>
> Is this still TODO ?No. I need to point to "Documentation/mergetools/vimdiff.txt".
I also noticed that the next paragraph was also not updated after the delimiters were changed (from ";", "-" and "|" to "+", "/" and ",").
I'll fix both issues in v7.
Thanks!