Re: [PATCH] doc: replace "--" with {litdd} in credential-cache/fsmonitor

From: Todd Zullinger <tmz@pobox.com>
Date: Apr 7, 2022, 18:05 UTC
Message-ID: <Yk8n6R33HrCCvSsP@pobox.com>
In-Reply-To: <nycvar.QRO.7.76.6.2204071528590.347@tvgsbejvaqbjf.bet>

Hi Johannes,

Johannes Schindelin wrote:

Show 15 quoted lines

> Hi Todd,
>> diff --git a/Documentation/config/core.txt b/Documentation/config/core.txt
>> index 889522956e..e67392cc83 100644
>> --- a/Documentation/config/core.txt
>> +++ b/Documentation/config/core.txt
>> @@ -63,7 +63,7 @@ core.protectNTFS::
>>
>>  core.fsmonitor::
>>  	If set to true, enable the built-in file system monitor
>> -	daemon for this working directory (linkgit:git-fsmonitor--daemon[1]).
>> +	daemon for this working directory (linkgit:git-fsmonitor{litdd}daemon[1]).
> 
> I am not quite certain that using `{litdd}` in a `linkgit` construct works
> both in AsciiDoc and AsciiDoctor, but I trust that you have verified that
> this works.

I did not do a build with asciidoc, but when I still built the Fedora packages with asciidoc, we had already fixed similar issues with `{litdd}` and I don't believe that has changed. If it has, then we've got other broken links:

    $ git grep 'linkgit:[^]]+\{litdd\}[^]]*\[' -- Documentation/ | wc -l
    8

    $ git grep 'linkgit:[^]]+--[^]]*\[' -- Documentation/ | wc -l
    0

> Thank you for doing this,

And thank you for reviewing and testing.

-- 
Todd