Re: [PATCH 0/2] Specify the actual pack size limit which is breached

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 23, 2022, 16:33 UTC
Message-ID: <YhZhvPcdD/C/LSMP@nand.local>
In-Reply-To: <pull.1158.git.1645632193.gitgitgadget@gmail.com>

On Wed, Feb 23, 2022 at 04:03:11PM +0000, Matt Cooper via GitGitGadget wrote:

Show 7 quoted lines

> Matt Cooper (2):
>   index-pack: clarify the breached limit
>   t5302: confirm that large packs mention limit
>
>  builtin/index-pack.c  | 8 ++++++--
>  t/t5302-pack-index.sh | 8 ++++++++
>  2 files changed, 14 insertions(+), 2 deletions(-)

I took a look and reviewed this series internally. The patches here match what I looked at within GitHub, so these look good to me also.

For what it's worth, I wouldn't mind to see these two patches squashed together, since it may be easier for future readers to see the new code and test together in the same patch.

But I don't feel strongly about it, so (with or without that suggestion) I'd be happy to see this get picked up. Thanks, Matt!

Thanks, Taylor