git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ds/commit-graph-gen-v2-fixes (was Re: What's cooking in git.git (Feb 2022, #08; Mon, 28))

From
Patrick Steinhardt <ps@pks.im>
Date
Mar 1, 2022, 14:58 UTC
Message-ID
<Yh40pJ1o0JHG5Op2@ncase>
In-Reply-To
<a296c8fc-9701-15bd-4459-e49f157adb56@github.com>
On Tue, Mar 01, 2022 at 09:26:51AM -0500, Derrick Stolee wrote:
Show 29 quoted lines
> On 3/1/2022 8:42 AM, Junio C Hamano wrote:
> 
> > * ds/commit-graph-gen-v2-fixes (2022-02-28) 4 commits
> >  - commit-graph: fix generation number v2 overflow values
> >  - commit-graph: start parsing generation v2 (again)
> >  - commit-graph: fix ordering bug in generation numbers
> >  - test-read-graph: include extra post-parse info
> > 
> >  Fixes to the way generation number v2 in the commit-graph files are
> >  (not) handled.
> > 
> >  Will merge to 'next'.
> >  source: <pull.1163.v2.git.1646056423.gitgitgadget@gmail.com>
> 
> Please hold for a re-roll on this one. Ævar has some feedback
> on these patches that merit a new version. His comments are
> mainly about test structure, but they will help get extra
> coverage in the 32-bit case.
> 
> Patrick also had some concerns about upgrading from older,
> buggy versions of Git. I think this isn't an issue [1] because of
> how those older versions would ignore existing corrected
> commit dates, but it would be good to get a common understanding
> of the scenario before merging this.
> 
> [1] https://lore.kernel.org/git/f50e74f0-9ffa-f4f2-4663-269801495ed3@github.com/
> 
> Thanks,
> -Stolee

Indeed, I think my concern is not an issue. The failures I was seeing were my own fault because I had been running an intermediate version of Git, which created those faulty graphs, and they carried over into later testing.

Patrick
Previous: Derrick StoleeNext: Junio C Hamano
Message 3 of 12 in “What's cooking in git.git (Feb 2022, #08; Mon, 28)”
  1. Junio C HamanoMar 1, 2022
  2. ds/commit-graph-gen-v2-fixes (was Re: What's cooking in git.git (Feb 2022, #08; Mon, 28))Derrick Stolee, Mar 1, 2022
  3. Patrick SteinhardtMar 1, 2022
  4. Junio C HamanoMar 1, 2022
  5. js/scalar-diagnose, was Re: What's cooking in git.git (Feb 2022, #08; Mon, 28)Johannes Schindelin, Mar 1, 2022
  6. Junio C HamanoMar 2, 2022
  7. en/merge-tree (Was: Re: What's cooking in git.git (Feb 2022, #08; Mon, 28))Elijah Newren, Mar 2, 2022
  8. Johannes SchindelinMar 7, 2022
  9. Elijah NewrenMar 8, 2022
  10. Johannes SchindelinMar 9, 2022
  11. ab/object-file-api-updates (was: What's cooking in git.git (Feb 2022, #08; Mon, 28))Ævar Arnfjörð Bjarmason, Mar 3, 2022
  12. Junio C HamanoMar 3, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.