Re: [PATCH] checkout: fix BUG() case in 9081a421a6

From: Todd Zullinger <tmz@pobox.com>
Date: Jan 20, 2022, 22:33 UTC
Message-ID: <YenjLhy3/q5Jnd+J@pobox.com>
In-Reply-To: <patch-1.1-21ddf7c628d-20220120T212233Z-avarab@gmail.com>

Hi,

Ævar Arnfjörð Bjarmason wrote:

Show 8 quoted lines

> Thanks to both you and Petr for the report and easy to reproduce case,
> and sorry about causing it.
> 
> In retrospec it's a rather obvious thinko. Here's a minimal fix for
> it, along with a derived test case that I made more exhaustive to
> check the state of the repo before, after, and in-between the two "git
> checkout" commands. As noted it'll also pass with 9081a421a6d
> reverted, showing that our behavior is the same as before that commit.

I can confirm the new test succeeds and the case which Petr reported works as it did in previous releases.

Many thanks for the quick fix and more extensive tests Ævar!

-- 
Todd