git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] leak tests: ignore some new leaks in a few tests

From
Taylor Blau <me@ttaylorr.com>
Date
Jan 18, 2022, 16:49 UTC
Message-ID
<YebvtSsivC9vGAbX@nand.local>
In-Reply-To
<pull.1192.git.git.1642176433017.gitgitgadget@gmail.com>
On Fri, Jan 14, 2022 at 04:07:12PM +0000, Elijah Newren via GitGitGadget wrote:
Show 6 quoted lines
> From: Elijah Newren <newren@gmail.com>
>
> These test scripts have not changed at all recently, but topics in seen
> have caused these to trigger the linux-leaks test.  It has been reported
> on list, so let's fix the claim that these are leak free and when
> someone investigates and fixes the problem, they can turn it back on.

I think this problem was likely introduced by a faulty patch in c2dbe00466 (Merge branch 'ps/avoid-unnecessary-hook-invocation-with-packed-refs' into seen, 2022-01-12), specifically 2e6b34bb1b (refs: open-code deletion of packed refs, 2022-01-07).

But the newer version 69840cc0f7 of the same patch (merged via 17d1824959) fixes the leak. As a result, all three of those once-failing tests now pass on 'seen' even when built with SANITIZE=leak.

We should be able to discard this patch as a result.

Thanks, Taylor

Previous: Elijah Newren via GitGitGadget
Message 2 of 2 in “leak tests: ignore some new leaks in a few tests”
  1. leak tests: ignore some new leaks in a few testsElijah Newren via GitGitGadget, Jan 14, 2022
  2. Taylor BlauJan 18, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.