Re: [BUG] Re: Git 2.35.0-rc0

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 11, 2022, 19:53 UTC
Message-ID: <Yd3gJ6C3jU7ZZskc@nand.local>
In-Reply-To: <010d01d8069e$8d330480$a7990d80$@nexbridge.com>

On Mon, Jan 10, 2022 at 10:51:39PM -0500, rsbecker@nexbridge.com wrote:

Show 9 quoted lines

> I now have a different issue:
>
> make -C t/ all
> make[1]: Entering directory '/home/git/git/t'
> rm -f -r 'test-results'
> /usr/coreutils/bin/bash: /usr/bin/perl: Argument list too long
>
> Is there anyway to move to xargs? I am not sure why /usr/bin/perl is
> having issues with the build.

Tracing through t/Makefile, I am _pretty_ sure that this Perl invocation comes from the test-lint-shell-syntax recipe.

I wonder if something like this would do the trick?

--- 8< ---

diff --git a/t/Makefile b/t/Makefile
index 46cd5fc527..d959119133 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -90,7 +90,7 @@ test-lint-executable:
 		echo >&2 "non-executable tests:" $$bad; exit 1; }

 test-lint-shell-syntax:
-	@'$(PERL_PATH_SQ)' check-non-portable-shell.pl $(T) $(THELPERS) $(TPERF)
+	@echo $(T) $(THELPERS) $(TPERF) | xargs '$(PERL_PATH_SQ)' check-non-portable-shell.pl

 test-lint-filenames:
 	@# We do *not* pass a glob to ls-files but use grep instead, to catch

--- >8 ---

Thanks,
Taylor