git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] repack: respect kept objects with '--write-midx -b'

From
Jeff King <peff@peff.net>
Date
Dec 20, 2021, 13:50 UTC
Message-ID
<YcCKQEpBbdgbAKrk@coredump.intra.peff.net>
In-Reply-To
<d10662af-4ce9-6944-aa73-ef344f6bdf67@gmail.com>
On Mon, Dec 20, 2021 at 08:40:09AM -0500, Derrick Stolee wrote:
Show 15 quoted lines
> > One could perhaps argue that the combined grep is less readable. If
> > that's a concern, I'd suggest wrapping it in a function like:
> > 
> >   # usage: check_trace2_arg <trace_file> <cmd> <arg>
> >   check_trace2_arg () {
> > 	grep "\"event\":\"start\".*\"$2\".*\"$3\"" "$1"
> >   }
> > 
> > All just suggestions, of course. I'd be happy enough to see the patch go
> > in as-is.
> 
> Thanks for the suggestions. I decided to adapt the 'test_subcommand'
> helper into a 'test_subcommand_inexact' helper. The existing helper
> requires the full argument list in exact order, but the new one only
> cares about the given arguments (in that relative order).

Heh, I should have looked to see if we had faced this problem before. Extending that family of helpers is better still than my suggestion.

-Peff
Previous: Derrick StoleeNext: Ævar Arnfjörð Bjarmason
Message 5 of 17 in “Two small 'git repack' fixes”
  1. 0/2 Two small 'git repack' fixesDerrick Stolee via GitGitGadget, Dec 17, 2021
  2. 1/2 repack: respect kept objects with '--write-midx -b'Derrick Stolee via GitGitGadget, Dec 17, 2021
  3. Jeff KingDec 17, 2021
  4. Derrick StoleeDec 20, 2021
  5. Jeff KingDec 20, 2021
  6. Ævar Arnfjörð BjarmasonDec 18, 2021
  7. 2/2 repack: make '--quiet' disable progressDerrick Stolee via GitGitGadget, Dec 17, 2021
  8. Jeff KingDec 17, 2021
  9. Derrick StoleeDec 20, 2021
  10. Jeff KingDec 20, 2021
  11. Derrick StoleeDec 20, 2021
  12. Ævar Arnfjörð BjarmasonDec 18, 2021
  13. Derrick StoleeDec 20, 2021
  14. 0/2 Two small 'git repack' fixesDerrick Stolee via GitGitGadget, Dec 20, 2021
  15. 2/2 repack: make '--quiet' disable progressDerrick Stolee via GitGitGadget, Dec 20, 2021
  16. 1/2 repack: respect kept objects with '--write-midx -b'Derrick Stolee via GitGitGadget, Dec 20, 2021
  17. Ævar Arnfjörð BjarmasonDec 20, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.