Re: [PATCH v3 0/3] vimdiff: new implementation with layout support

From: Fernando Ramos <greenfoo@u92.eu>
Date: Dec 1, 2021, 18:49 UTC
Message-ID: <YafDzJmSHoiJFmKT@zacax395.localdomain>
In-Reply-To: <CAPig+cQg=P1BNCwfmNAE3oHZHh4CPJ5QNQh-vgfOQDGGwenMow@mail.gmail.com>

On 21/12/01 12:03AM, Eric Sunshine wrote:

Show 6 quoted lines

> Just a side note: I understand that [1] recommended adding the "$"
> inside arithmetic expressions, but by chance I happened to be browsing
> the history of CodingGuidelines and ran across 32b5fe7f0e
> (CodingGuidelines: drop arithmetic expansion advice to use "$x",
> 2020-05-04) which dropped[2] the recommendation to use "$" inside the
> expression. Anyhow, certainly not worth a re-roll.

I don't mind preparing a v4 with this change. I also think it makes the code cleaner. I'll do that :)

> By the way, since you've removed Bashisms, do you still need the
> `#!/bin/bash` at the top of the script?

Good catch. Will do.

I'll wait a few more days for extra comments and prepare a v4 with these changes. Thanks for the suggestions.