Re: Regression in 8d92fb292706 ("dir: replace exponential algorithm with a linear one")

On 2021-12-06 at 12:16:39, Uwe Kleine-König wrote:

I don't think so. The old behavior was to add a file that's under a different repository (subdir), which is bizarre and at least to me, unexpected. I believe the new behavior causes us to not add the file because it belongs to a different repo, which seems correct.

I have no clue how we could practically check out the file in the first situation if subdir remains a git repository. Even if it does work, it is likely to lead to confusing behavior when the index for subdir is not in sync with the index for the main repo.

If I'm missing something here, though, please do point it out.