git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] diff histogram: intern strings

From
Jeff King <peff@peff.net>
Date
Nov 18, 2021, 15:42 UTC
Message-ID
<YZZ0e7CCGW5QbQlW@coredump.intra.peff.net>
In-Reply-To
<nycvar.QRO.7.76.6.2111181631260.11028@tvgsbejvaqbjf.bet>
On Thu, Nov 18, 2021 at 04:35:48PM +0100, Johannes Schindelin wrote:
Show 7 quoted lines
> I think the really important thing to point out is that
> `xdl_classify_record()` ensures that the `ha` attribute is different for
> different text. AFAIR it even "linearizes" the `ha` values, i.e. they
> won't be all over the place but start at 0 (or 1).
> 
> So no, I'm not worried about collisions. That would be a bug in
> `xdl_classify_record()` and I think we would have caught this bug by now.

Ah, thanks for that explanation. That addresses my collision concern from earlier in the thread completely.

-Peff
Previous: Johannes SchindelinNext: Phillip Wood
Message 7 of 15 in “xdiff: speedup histogram diff”
  1. 0/3 xdiff: speedup histogram diffPhillip Wood via GitGitGadget, Nov 17, 2021
  2. 1/3 diff histogram: intern stringsPhillip Wood via GitGitGadget, Nov 17, 2021
  3. Derrick StoleeNov 17, 2021
  4. Jeff KingNov 17, 2021
  5. Phillip WoodNov 17, 2021
  6. Johannes SchindelinNov 18, 2021
  7. Jeff KingNov 18, 2021
  8. Phillip WoodNov 19, 2021
  9. Jeff KingNov 19, 2021
  10. Ævar Arnfjörð BjarmasonNov 19, 2021
  11. Jeff KingNov 19, 2021
  12. Johannes SchindelinNov 19, 2021
  13. 2/3 xdiff: avoid unnecessary memory allocationsPhillip Wood via GitGitGadget, Nov 17, 2021
  14. 3/3 xdiff: simplify comparisonPhillip Wood via GitGitGadget, Nov 17, 2021
  15. Johannes SchindelinNov 18, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.