git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] trace2: increment event format version

From
Josh Steadmon <steadmon@google.com>
Date
Nov 11, 2021, 23:06 UTC
Message-ID
<YY2h5lO90vo3Dy42@google.com>
In-Reply-To
<xmqqh7cijnwx.fsf@gitster.g>
On 2021.11.11 15:03, Junio C Hamano wrote:
Show 16 quoted lines
> Josh Steadmon <steadmon@google.com> writes:
> 
> > In 64bc752 (trace2: add trace2_child_ready() to report on background
> > children, 2021-09-20), we added a new "child_ready" event. In
> > Documentation/technical/api-trace2.txt, we promise that adding a new
> > event type will result in incrementing the trace2 event format version
> > number, but this was not done. Correct this in code & docs.
> >
> > Signed-off-by: Josh Steadmon <steadmon@google.com>
> > ---
> >  Documentation/technical/api-trace2.txt | 4 ++--
> >  trace2/tr2_tgt_event.c                 | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> Hmph, it seems to me that this is better done before the release,
> or am I mistaken?

Ideally yes, although I am not sure if there is anyone using traces who strongly depends on the accuracy of the evt field. For release-blocking fixes (for lack of a better term), should I have sent this patch differently?

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 9 in “trace2: increment event format version”
  1. trace2: increment event format versionJosh Steadmon, Nov 11, 2021
  2. Junio C HamanoNov 11, 2021
  3. Josh SteadmonNov 11, 2021
  4. Junio C HamanoNov 11, 2021
  5. Ævar Arnfjörð BjarmasonNov 12, 2021
  6. Junio C HamanoNov 12, 2021
  7. Jeff HostetlerDec 1, 2021
  8. Ævar Arnfjörð BjarmasonDec 1, 2021
  9. Josh SteadmonDec 1, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.