Re: [PATCH] allow disabling fsync everywhere

From: Jeff King <peff@peff.net>
Date: Oct 28, 2021, 14:36 UTC
Message-ID: <YXq1g4Zwfq8gJEoC@coredump.intra.peff.net>
In-Reply-To: <20211028002102.19384-1-e@80x24.org>

On Thu, Oct 28, 2021 at 12:21:02AM +0000, Eric Wong wrote:

Show 12 quoted lines

> "core.fsync" and the "GIT_FSYNC" environment variable now exist
> for disabling fsync() even on packfiles and other critical data.
> 
> Running "make test -j8 NO_SVN_TESTS=1" on a noisy 8-core system
> on an HDD, adding "GIT_FSYNC=0" to the invocation brings my test
> runtime from ~4 minutes down to ~3 minutes.
> 
> SVN interopability tests are minimally affected since SVN will
> still use fsync in various places.
> 
> This will also be useful for 3rd-party tools which create
> throwaway git repositories of temporary data.

Do you mostly just care about the tests, or is the third-party tool support important to you? I ask because most of us switched to running the tests with --root=/some/tmpfs long ago to achieve the same speedup.

-Peff