Re: git format-patch --signoff

From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Oct 21, 2021, 23:37 UTC
Message-ID: <YXH5rKsjPIeWSGTE@qmqm.qmqm.pl>
In-Reply-To: <xmqqo87ihurk.fsf@gitster.g>

On Thu, Oct 21, 2021 at 03:34:39PM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Michał Mirosław <mirq-linux@rere.qmqm.pl> writes:
> 
> > I just noticed that `git format-patch --signoff` adds the 'Signed-off-by'
> > line even if the exact same line is already present in the commit message.
> > Could this be avoided in the tool?
> >
> > git version 2.30.2
> >
> > Best Regards
> > Michał Mirosław
> 
> The rule should be "avoid adding the same sign-off as the one at the
> end".  In other words, as a record of the flow of patch custody,

[...]

> This test hasn't changed since it was written in Feb 2013, and I
> think 2.30.2 is recent enough to conform to the rule to pass this
> test.

The test indeed works correctly, and I couldn't reproduce the effect on a fresh git repo. I finally took a look with hexdump on the output: the culprit was a UTF-8 non-breaking space -- indistinguishable on a terminal from a normal space. I'm not sure what to think about this... Sorry for the noise.

Best Regards Michał Mirosław