Re: [PATCH] for-each-ref: delay parsing of --sort=<atom> options
- From
Jeff King <peff@peff.net>
- Date
- Oct 20, 2021, 20:48 UTC
- Message-ID
- <YXCAuAwZenM6EPug@coredump.intra.peff.net>
- In-Reply-To
- <xmqq4k9bssr7.fsf@gitster.g>
On Wed, Oct 20, 2021 at 06:58:04AM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> However, it is tricky to arrange, as the command already takes > multiple --sort keys, and the laster ones are taken as more > significant sort order, so it is tricky to come up with two keys A > and B such that --sort=A --no-sort --sort=B will produce one order, > while --sort=A --sort=B will produce another different order.
Yeah, I faced something similar with 7c5045fc18 (ref-filter: apply fallback refname sort only after all user sorts, 2020-05-03). I suspect you could use the same keys as those tests, though I am OK if we simply leave it as a quietly-fixed bug.
-Peff