Re: [PATCH 0/5] refs: remove long-dead code

From: Jeff King <peff@peff.net>
Date: Sep 28, 2021, 17:58 UTC
Message-ID: <YVNX2QrdR7XZFfqA@coredump.intra.peff.net>
In-Reply-To: <cover-0.5-00000000000-20210928T130032Z-avarab@gmail.com>

On Tue, Sep 28, 2021 at 03:02:19PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 5 quoted lines

> This removes dead code in the refs backend, mainly in the
> ref-cache. By line count this is mostly a straightforward follow-up to
> 9939b33d6a3 (packed-backend: rip out some now-unused code, 2017-09-08)
> and 9dd389f3d8d (packed_ref_store: get rid of the `ref_cache`
> entirely, 2017-09-25).

Thanks, all five look good to me.

Reading through I was surprised the loose backend didn't use add_ref_entry(), but that's because it uses add_entry_to_dir() more directly. And that also explains why the "incomplete" parameter in the final patch was always 1: in the loose world, we are always reading as incrementally as possible.

So patches 2-4 are really just fallout from switching the packed-refs reading away from ref-cache. Makes sense.

-Peff