Re: [PATCH] bundle: remove ignored & undocumented "--verbose" flag

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 23, 2021, 17:38 UTC
Message-ID: <YUy7mkaRCLKrMJBw@nand.local>
In-Reply-To: <patch-1.1-d61f4b28dfd-20210923T164636Z-avarab@gmail.com>

On Thu, Sep 23, 2021 at 06:48:22PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 11 quoted lines

> In 73c3253d75e (bundle: framework for options before bundle file,
> 2019-11-10) the "git bundle" command was refactored to use
> parse_options(). In that refactoring it started understanding the
> "--verbose" flag before the subcommand, e.g.:
>
>     git bundle --verbose verify --quiet
>
> However, nothing ever did anything with this "verbose" variable, and
> the change wasn't documented. It appears to have been something that
> escaped the lab, and wasn't flagged by reviewers at the time. Let's
> just remove it.

Thanks; this looks good to me. We never use the `verbose` variable for anything, and it isn't documented. So I agree that it can be removed.

Thanks for cleaning this up:

    Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor