Re: [PATCH] http: match headers case-insensitively when redacting

From: Jeff King <peff@peff.net>
Date: Sep 22, 2021, 02:32 UTC
Message-ID: <YUqVoVgt47E80HhV@coredump.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.2109212351440.26668@fvyyl>

On Wed, Sep 22, 2021 at 12:00:03AM +0200, Daniel Stenberg wrote:

Show 8 quoted lines

> > At any rate, I wonder if it would be friendlier for curl to hand strings
> > to the debug function with the usual capitalization.
> 
> Maybe that could've been a good idea if we had done it when we introduced
> HTTP/2 support. Now, I think that ship has sailed already as libcurl has
> supported HTTP/2 since late 2013 and changing anything like that now will
> just risk introducing the reverse surprise in applications. Better not rock
> that boat now methinks.

Oof, that's much older than I realized. I agree the ship has long sailed, and we are better off leaving things as-is.

Show 6 quoted lines

> > PS This nit aside, it is totally cool that I have been seamlessly using
> >   HTTP/2 to talk to github.com without even realizing it. I wonder for
> >   how long!
> 
> I don't know when github.com started supporting h2, but since libcurl 7.62.0
> (released Oct 31, 2018) it has negotiated h2 by default over HTTPS.

I dug a bit. Looks like it was enabled at the load-balancing layer of github.com around January of this year.

-Peff