Re: [PATCH v3 2/5] environment.c: remove test-specific "ignore_untracked..." variable

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 20, 2021, 22:10 UTC
Message-ID: <YUkG1u7utvi6+VgS@nand.local>
In-Reply-To: <patch-v3-2.5-ece340af764-20210919T084703Z-avarab@gmail.com>

On Sun, Sep 19, 2021 at 10:47:16AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> Instead of the global ignore_untracked_cache_config variable added in
> dae6c322fa1 (test-dump-untracked-cache: don't modify the untracked
> cache, 2016-01-27) we can make use of the new facility to set config
> via environment variables added in d8d77153eaf (config: allow
> specifying config entries via envvar pairs, 2021-01-12).
>
> It's arguably a bit hacky to use setenv() and getenv() to pass
> messages between the same program, but since the test helpers are not
> the main intended audience of repo-settings.c I think it's better than
> hardcoding the test-only special-case in prepare_repo_settings().

Hmm. I tend to agree that using (a wrapper over) setenv() to pass messages between the test helper and the rest of Git is a little bit of a hack.

Everything you wrote should work based on my understanding of the config-over-environment-variable stuff added recently. But I wish that it didn't involve losing some grep-ability between the test-helper and library code.

So I wouldn't be sad to see this patch get dropped, and I also wouldn't be overly sad to see it get picked up, either. But I don't think it's a necessary step, and we may be slightly better without it.

Thanks, Taylor