Re: [PATCH v2 0/2] reroll for cb/plug-leaks-in-alloca-emu-users
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Sep 16, 2021, 16:53 UTC
- Message-ID
- <YUN2lwA3w8zAoYhS@nand.local>
- In-Reply-To
- <20210916085523.68581-1-carenas@gmail.com>
On Thu, Sep 16, 2021 at 01:55:21AM -0700, Carlo Marcelo Arenas Belón wrote:
> v2 includes all suggestions and feedback, and tries probably too hard > to modify the last test in a way that wouldn't require long lines.
Thanks, this version looks good to me. I suspect the "tries probably too hard" is referring to putting the sed expressions into a file and then loading them from that file with `-f`.
I wouldn't mind the long line, or splitting it across multiple lines with `\`. But what you wrote is fine, too.
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Thanks, Taylor
BTW: no need to put "reroll for" in the subject line for this series. The [PATCH v2] indicates that it is a reroll.