git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] reroll for cb/plug-leaks-in-alloca-emu-users

From
Taylor Blau <me@ttaylorr.com>
Date
Sep 16, 2021, 16:53 UTC
Message-ID
<YUN2lwA3w8zAoYhS@nand.local>
In-Reply-To
<20210916085523.68581-1-carenas@gmail.com>
On Thu, Sep 16, 2021 at 01:55:21AM -0700, Carlo Marcelo Arenas Belón wrote:
> v2 includes all suggestions and feedback, and tries probably too hard
> to modify the last test in a way that wouldn't require long lines.

Thanks, this version looks good to me. I suspect the "tries probably too hard" is referring to putting the sed expressions into a file and then loading them from that file with `-f`.

I wouldn't mind the long line, or splitting it across multiple lines with `\`. But what you wrote is fine, too.

  Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

BTW: no need to put "reroll for" in the subject line for this series.
The [PATCH v2] indicates that it is a reroll.
Previous: Carlo Marcelo Arenas Belón
Message 15 of 15 in “t0000: truly leak free”
  1. 0/2 t0000: truly leak freeCarlo Marcelo Arenas Belón, Sep 16, 2021
  2. 1/2 tree-diff: fix leak when not HAVE_ALLOCACarlo Marcelo Arenas Belón, Sep 16, 2021
  3. Taylor BlauSep 16, 2021
  4. Junio C HamanoSep 16, 2021
  5. 2/2 t0000: avoid masking git exit value through pipesCarlo Marcelo Arenas Belón, Sep 16, 2021
  6. Taylor BlauSep 16, 2021
  7. Junio C HamanoSep 16, 2021
  8. Taylor BlauSep 16, 2021
  9. Junio C HamanoSep 16, 2021
  10. Ævar Arnfjörð BjarmasonSep 16, 2021
  11. 0/2 reroll for cb/plug-leaks-in-alloca-emu-usersCarlo Marcelo Arenas Belón, Sep 16, 2021
  12. 1/2 tree-diff: fix leak when not HAVE_ALLOCA_HCarlo Marcelo Arenas Belón, Sep 16, 2021
  13. Jeff KingSep 16, 2021
  14. 2/2 t0000: avoid masking git exit value through pipesCarlo Marcelo Arenas Belón, Sep 16, 2021
  15. Taylor BlauSep 16, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.