git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] pack-revindex.h: correct the time complexity descriptions

From
Taylor Blau <me@ttaylorr.com>
Date
Sep 16, 2021, 05:10 UTC
Message-ID
<YULRwFhL/T44ygpe@nand.local>
In-Reply-To
<pull.1039.v2.git.1631696964072.gitgitgadget@gmail.com>
On Wed, Sep 15, 2021 at 09:09:23AM +0000, Kyle Zhao via GitGitGadget wrote:
> From: kylezhao <kylezhao@tencent.com>
>
> Time complexities for pack_pos_to_midx and midx_to_pack_pos are swapped,
> correct it.

Great eyes! Thanks for noticing and fixing. I took a look through the other three functions which convert between pack offset, pack position, and index position, and those had the correct runtime noted.

But these two were swapped, and are now correct after your patch. Thanks again.

    Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

Previous: Bagas SanjayaNext: Junio C Hamano
Message 5 of 6 in “pack-revindex.h: fix typos of time complexity”
  1. pack-revindex.h: fix typos of time complexityKyle Zhao via GitGitGadget, Sep 15, 2021
  2. Bagas SanjayaSep 15, 2021
  3. pack-revindex.h: correct the time complexity descriptionsKyle Zhao via GitGitGadget, Sep 15, 2021
  4. Bagas SanjayaSep 15, 2021
  5. Taylor BlauSep 16, 2021
  6. Junio C HamanoSep 16, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.