Re: What's cooking in git.git (Sep 2021, #04; Mon, 13)

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 14, 2021, 05:43 UTC
Message-ID: <YUA2ajsm8q2EtH9h@nand.local>
In-Reply-To: <xmqqtuinc3tx.fsf@gitster.g>

On Mon, Sep 13, 2021 at 07:02:02PM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> * tb/repack-write-midx (2021-09-10) 8 commits
>  - builtin/repack.c: pass `--refs-snapshot` when writing bitmaps
>  - builtin/repack.c: make largest pack preferred
>  - builtin/repack.c: support writing a MIDX while repacking
>  - builtin/repack.c: extract showing progress to a variable
>  - builtin/repack.c: keep track of existing packs unconditionally
>  - midx: preliminary support for `--refs-snapshot`
>  - builtin/multi-pack-index.c: support --stdin-packs mode
>  - midx: expose 'write_midx_file_only()' publicly
>  (this branch uses tb/multi-pack-bitmaps.)
>
>  "git repack" has been taught to generate multi-pack reachability
>  bitmaps.

I think that this is in a good state, although I would like to get another review (particularly it would be good to have somebody weigh in on the --refs-snapshot format question that Ævar raised [1]).

[1]: https://lore.kernel.org/git/87sfyb8ihg.fsf@evledraar.gmail.com/

Show 9 quoted lines

> * tb/midx-write-propagate-namehash (2021-09-12) 4 commits
>  - t5326: test propagating hashcache values
>  - midx.c: respect 'pack.writeBitmapHashcache' when writing bitmaps
>  - pack-bitmap.c: propagate namehash values from existing bitmaps
>  - t/helper/test-bitmap.c: add 'dump-hashes' mode
>  (this branch uses tb/multi-pack-bitmaps.)
>
>  "git multi-pack-bitmap write" learns to propagate the hashcache
>  from original bitmap to resulting bitmap.

Another reroll coming, but the series is mostly unchanged (the reroll fixes a couple of test and perf-test related bugs and adds some performance numbers).

One small nit, s/multi-pack-bitmap write/multi-pack-index write --bitmap/.

Thanks, Taylor