Re: git log --encoding=HTML is not supported

From: Jeff King <peff@peff.net>
Date: Aug 27, 2021, 18:37 UTC
Message-ID: <YSkw6DSHenXHGx0b@coredump.intra.peff.net>
In-Reply-To: <xmqqk0k6c1zn.fsf@gitster.g>

On Fri, Aug 27, 2021 at 08:59:40AM -0700, Junio C Hamano wrote:

Show 17 quoted lines

> Krzysztof Żelechowski <giecrilj@stegny.2a.pl> writes:
> 
> > Dnia czwartek, 26 sierpnia 2021 17:37:40 CEST Junio C Hamano pisze:
> >>         git log --html \
> >>                 --format='<tr><td>%h</td><td>%s</td>...</tr>'
> >
> > I would like to be able to say:
> >  { git config i18n.logOutputEscape HTML; }
> >
> > What do you think?
> 
> It depends on what it does.
> 
> If the configuration means that "git log" output (with any supported
> options, like "-p") will be given with '<' written to '^lt;' etc. so
> that it becomes safe to dump it in HTML, it fails to interest me at
> all.

Yeah, I think things get pretty weird when you start thinking about dumping whole filenames and diff contents.

I wouldn't be opposed to an option for the pretty formatter to have encodings. Something like:

  git log --format='%(authorname:quote=html)'

I'd probably put off implementing that until we actually unify the for-each-ref and pretty formats, though (we do not even have %(authorname) at this point!). The latter already has a quoting mechanism for shell/perl/python/tcl (though it is not per-atom, and I wouldn't be opposed to a --format-quote option that quoted all pretty.c placeholders).

-Peff