Re: [PATCH v2] multi-pack-index: fix *.rev cleanups with --object-dir

From: Jeff King <peff@peff.net>
Date: Aug 23, 2021, 17:56 UTC
Message-ID: <YSPhTw6biUCxNrq6@coredump.intra.peff.net>
In-Reply-To: <YSPWQtOjKVgIKqsd@nand.local>

On Mon, Aug 23, 2021 at 01:09:22PM -0400, Taylor Blau wrote:

Show 15 quoted lines

> On Mon, Aug 23, 2021 at 07:05:31PM +0200, Johannes Berg wrote:
> > On Mon, 2021-08-23 at 12:06 -0400, Jeff King wrote:
> > > I'm not entirely convinced that writing a midx when not "inside" a repo
> > > is something that we want to support. But if we do, then...
> >
> > Seemed like that was the point of --object-dir?
> 
> Stolee (cc'd) would know more as the original author, but as I recall
> the point of `--object-dir` was to be able to write a midx in
> directories which were acting as Git repositories, but didn't contain a
> `.git` directory.
> 
> It's kind of a strange use-case, but I recall that it was important at
> the time. Maybe he could shed more light on why. (Either way, we're
> stuck with it ;)).

And the point was that those directories would also be alternates of the current repo (and that there is a current repo). That's one of the things that your midx-bitmap series tightens.

-Peff