git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat: let git_mmap use malloc(3) directly

From
Jeff King <peff@peff.net>
Date
Aug 23, 2021, 16:15 UTC
Message-ID
<YSPJqc3vVa7ZX63m@coredump.intra.peff.net>
In-Reply-To
<9c2fe5de-be23-3e66-6edf-3c2edfb804f3@web.de>
On Sat, Aug 21, 2021 at 02:52:40PM +0200, René Scharfe wrote:
Show 5 quoted lines
> xmalloc() dies on error, allows zero-sized allocations and enforces
> GIT_ALLOC_LIMIT for testing.  Our mmap replacement doesn't need any of
> that.  Let's cut out the wrapper, reject zero-sized requests as required
> by POSIX and use malloc(3) directly.  Allocation errors were needlessly
> handled by git_mmap() before; this code becomes reachable now.

Thanks, this is a good idea. As you note, the function was already expecting a possible NULL return. And I think in general it's good for our compat/ wrappers to stay as close to the OS-level functions they're emulating as possible.

-Peff
Previous: René ScharfeNext: Johannes Schindelin
Message 2 of 3 in “compat: let git_mmap use malloc(3) directly”
  1. compat: let git_mmap use malloc(3) directlyRené Scharfe, Aug 21, 2021
  2. Jeff KingAug 23, 2021
  3. Johannes SchindelinAug 23, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.