Re: [PATCH] ls-remote: set packet_trace_identity(<name>)

From: Jeff King <peff@peff.net>
Date: Aug 23, 2021, 16:08 UTC
Message-ID: <YSPH4PoRG78Ybv0J@coredump.intra.peff.net>
In-Reply-To: <patch-1.1-5d3a2b96500-20210823T131533Z-avarab@gmail.com>

On Mon, Aug 23, 2021 at 03:17:49PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 11 quoted lines

> Set packet_trace_identity() for ls-remote. This replaces the generic
> "git" identity in GIT_TRACE_PACKET=<file> traces to "ls-remote", e.g.:
> 
>     [...] packet:  upload-pack> version 2
>     [...] packet:  upload-pack> agent=git/2.32.0-dev
>     [...] packet:    ls-remote< version 2
>     [...] packet:    ls-remote< agent=git/2.32.0-dev
> 
> Where in an "git ls-remote file://<path>" dialog ">" is the sender (or
> "to the server") and "<" is the recipient (or "received by the
> client").

Thanks, this looks like an obvious improvement. I'm a little surprised it wasn't there already, but I guess I just missed it way back in bbc30f9963 (add packet tracing debug code, 2011-02-24).

-Peff