Re: Git is removing . from the last part of user.name
- From
Jeff King <peff@peff.net>
- Date
- Aug 22, 2021, 19:35 UTC
- Message-ID
- <YSKm8Q8nyTavQaox@coredump.intra.peff.net>
- In-Reply-To
- <YSKleNynVrWWyyML@coredump.intra.peff.net>
On Sun, Aug 22, 2021 at 03:28:57PM -0400, Jeff King wrote:
> On a somewhat lesser note, I'm tempted to say that "." probably was > never that useful (compared to say, comma, which is the gecos > separator), and we could probably just drop it from the crud list.
This does break a few tests, but none that I think explicitly were arguing for keeping the dot. One was just a general crud test, and the other was just documenting the current behavior while testing something else (and perhaps even argues _for_ the change, as somebody bothered to write --author='Jane D.' in the first place).
---
diff --git a/ident.c b/ident.c index 85d9ba7120..2d136d27c8 100644 --- a/ident.c +++ b/ident.c @@ -198,7 +198,6 @@ void reset_ident_date(void) static int crud(unsigned char c) { return c <= 32 || - c == '.' || c == ',' || c == ':' || c == ';' || diff --git a/t/t4203-mailmap.sh b/t/t4203-mailmap.sh index 0b2d21ec55..a1cdc2905f 100755 --- a/t/t4203-mailmap.sh +++ b/t/t4203-mailmap.sh @@ -466,7 +466,7 @@ test_expect_success 'gitmailmap(5) example output: example #1' ' Author Jane Doe <jane@laptop.(none)> maps to Jane Doe <jane@laptop.(none)> Committer C O Mitter <committer@example.com> maps to C O Mitter <committer@example.com> - Author Jane D <jane@desktop.(none)> maps to Jane Doe <jane@desktop.(none)> + Author Jane D. <jane@desktop.(none)> maps to Jane Doe <jane@desktop.(none)> Committer C O Mitter <committer@example.com> maps to C O Mitter <committer@example.com> EOF git -C doc log --reverse --pretty=format:"Author %an <%ae> maps to %aN <%aE>%nCommitter %cn <%ce> maps to %cN <%cE>%n" >actual && @@ -494,7 +494,7 @@ test_expect_success 'gitmailmap(5) example output: example #2' ' Author Jane Doe <jane@laptop.(none)> maps to Jane Doe <jane@example.com> Committer C O Mitter <committer@example.com> maps to C O Mitter <committer@example.com> - Author Jane D <jane@desktop.(none)> maps to Jane Doe <jane@example.com> + Author Jane D. <jane@desktop.(none)> maps to Jane Doe <jane@example.com> Committer C O Mitter <committer@example.com> maps to C O Mitter <committer@example.com> EOF git -C doc log --reverse --pretty=format:"Author %an <%ae> maps to %aN <%aE>%nCommitter %cn <%ce> maps to %cN <%cE>%n" >actual && diff --git a/t/t7518-ident-corner-cases.sh b/t/t7518-ident-corner-cases.sh index 905957bd0a..738c723861 100755 --- a/t/t7518-ident-corner-cases.sh +++ b/t/t7518-ident-corner-cases.sh @@ -18,7 +18,7 @@ test_expect_success 'empty name and missing email' ' ' test_expect_success 'commit rejects all-crud name' ' - test_must_fail env GIT_AUTHOR_NAME=" .;<>" \ + test_must_fail env GIT_AUTHOR_NAME=" ,;<>" \ git commit --allow-empty -m foo '