Re: [PATCH] make: add INSTALL_STRIP variable

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: Aug 21, 2021, 10:35 UTC
Message-ID: <YSDW3nsG2iWPGakF@danh.dev>
In-Reply-To: <70e609f5-bf40-658a-a021-ab7a0ad4baa1@gmail.com>

On 2021-08-21 15:24:22+0700, Bagas Sanjaya <bagasdotme@gmail.com> wrote:

Show 23 quoted lines

> On 20/08/21 18.36, Đoàn Trần Công Danh wrote:
> > I believe it's better to write like this:
> > 
> > ----- 8< ------
> > ifdef INSTALL_STRIP
> > install: strip
> > endif
> > 
> > install: all
> > 	....
> > ---- >8-------
> > 
> > IOW, install depends on strip, not install invoke strip.
> 
> Oh, I missed that.
> 
> > I think it would work better for:
> > 
> > 	make install strip
> > 
> 
> Wouldn't it install unstripped binaries to the prefix then stripping them in
> the build directory?

No, with:

	install: strip

strip is one of install's dependencies, then strip will be executed before install.

-- 
Danh