Re: Bug: Segmentation fault in git diff

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: Aug 18, 2021, 10:44 UTC
Message-ID: <YRzkq47gOGfn8zsw@danh.dev>
In-Reply-To: <40BE2EF2-0AF3-45BA-9880-8A6011B38D03@slight.dev>

On 2021-08-18 10:42:45+0200, Thomas De Zeeuw <thomas@slight.dev> wrote:

Show 7 quoted lines

> Hello,
> 
> This is my first bug report to Git mailing list so let me know if more information is needed.
> 
> Running the following command results in a segmentation fault on macOS arm64
> $ git diff --name-only --diff-filter=U —relative
> Segmentation fault: 11

MVCE:

---- 8< --- #!/bin/sh

rm -rf /tmp/diff-bug git init /tmp/diff-bug cd /tmp/diff-bug mkdir -p dir

printf '%s\n' one two three >file printf '%s\n' inner >dir/file git add file dir/file git commit -m first

git branch side

printf '%s\n' one two >file git add file git commit -m checkpoint git tag checkpoint

git switch side printf '%s\n' two two four >file git add file git commit -m side

cd dir git rebase checkpoint

git diff --name-only --relative ---- >8 -----

It's NULL pointer dereference bug because pair is NULL. I haven't check further:

---- 8< -----
#0  run_diff_files (revs=revs@entry=0x7ffcc85ae270, option=option@entry=0)
    at diff-lib.c:196
196                                     pair->two->mode = wt_mode;
----- >8 -----

-- 
Danh