git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: send-email issue

From
Jeff King <peff@peff.net>
Date
Aug 16, 2021, 16:57 UTC
Message-ID
<YRqY4Tw4YxbepuFg@coredump.intra.peff.net>
In-Reply-To
<xmqq4kbps58l.fsf@gitster.g>
On Mon, Aug 16, 2021 at 09:51:06AM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> >> tls -> starttls
> >> ssl -> smtps
> >> 
> >> This way we don't have to change anything, and "smtps" is a valid way to refer
> >> to smtp over ssl (e.g. see /etc/services for 465/tcp).
> >
> > FWIW, those options make quite a bit of sense to me (and I agree the
> > transition to them would be easy).
> 
> Back when we had the original discussion in April [*], I think we
> found one small glitch that we need to solve before we can start
> introducing aliases---setting the variable to unknown value (imagine
> you set it to 'starttls' and then run a version of Git that does not
> know it yet) does not make Git barf but silently ignore.
> 
> And that needs to be changed to die, and versions of Git with such a
> change, without any alias added, should be allowed to spread to
> eradicate the "silently ignore" version, before we can safely start
> adding aliases.

This is certainly unfortunate, but IMHO is not a hard requirement for adding new values. This is no different than a case where we add a new config option, but old versions of Git quietly ignore it.

In other words, I would suggest to tighten this as the values are added, but not worry about having a "spreading" period.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 13 in “send-email issue”
  1. Ben GoldbergAug 13, 2021
  2. Ben GoldbergAug 13, 2021
  3. Ben GoldbergAug 13, 2021
  4. Konstantin RyabitsevAug 13, 2021
  5. Ben GoldbergAug 13, 2021
  6. Junio C HamanoAug 14, 2021
  7. Konstantin RyabitsevAug 16, 2021
  8. Jeff KingAug 16, 2021
  9. Junio C HamanoAug 16, 2021
  10. Jeff KingAug 16, 2021
  11. Junio C HamanoAug 16, 2021
  12. Ævar Arnfjörð BjarmasonAug 23, 2021
  13. Junio C HamanoAug 24, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.