Re: [PATCH v2] t5607: avoid using prerequisites to select algorithm

From: Jeff King <peff@peff.net>
Date: Aug 11, 2021, 23:30 UTC
Message-ID: <YRRdjgzjokT1nQmG@coredump.intra.peff.net>
In-Reply-To: <20210811231644.570030-1-sandals@crustytoothpaste.net>

On Wed, Aug 11, 2021 at 11:16:44PM +0000, brian m. carlson wrote:

Show 11 quoted lines

> In this test, we currently use the SHA1 prerequisite to specify the
> algorithm we're using to test, since SHA-256 bundles are always v3,
> whereas SHA-1 bundles default to v2, and as a result the default output
> differs.
> 
> However, this causes a problem if we run with GIT_TEST_FAIL_PREREQS set,
> since that means that we'll unexpectedly fail the SHA1 prerequisite,
> resulting in incorrect expected output.  Let's fix this by checking
> against the built-in data called "algo", which tells us which algorithm
> is in use.  This should work in any situation, making our test a little
> more robust.

Thanks, this seems like a reasonable step, and fixes the test for me.

I still get tons of other failures because I set GIT_TEST_HTTPD=yes, which implies to me we should still be fixing GIT_TEST_FAIL_PREREQS. But I am happy to take this in the meantime for people who do care.

-Peff