git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix leak in credential_apply_config

From
Jeff King <peff@peff.net>
Date
Aug 20, 2021, 17:57 UTC
Message-ID
<YR/tETCiv3TqqEPH@coredump.intra.peff.net>
In-Reply-To
<YR/sxISzR0RebVMZ@coredump.intra.peff.net>
On Fri, Aug 20, 2021 at 01:56:20PM -0400, Jeff King wrote:
Show 6 quoted lines
> > It would help unify the handling of code that is somewhat
> > duplicated (but slightly different each time) across
> > credential_apply_config(), http_init(), get_urlmatch(),
> > and cmd__urlmatch_normalization().
> 
> Agreed. It looks like http_init() has the same leak that is fixed here.

Oh, nevermind. That call is indeed correct. Apparently if you re-order two lines I'm unable to see them. ;)

-Peff
Previous: Jeff King
Message 4 of 4 in “Fix leak in credential_apply_config”
  1. Fix leak in credential_apply_configMike Hommey, Aug 20, 2021
  2. Derrick StoleeAug 20, 2021
  3. Jeff KingAug 20, 2021
  4. Jeff KingAug 20, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.