git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] multi-pack-index: fix potential segfault without sub-command

From
Jeff King <peff@peff.net>
Date
Jul 23, 2021, 07:34 UTC
Message-ID
<YPpxA1XWw65pRr0P@coredump.intra.peff.net>
In-Reply-To
<12804130427fd71e88ce10aed283c1f9cdd330ef.1626886330.git.me@ttaylorr.com>
On Wed, Jul 21, 2021 at 12:52:37PM -0400, Taylor Blau wrote:
> I didn't realize that we are veering away from test_i18ngrep in new
> tests, so here's a version of this trivial patch with grep instead.

This looks fine to me, but it looks like Junio may have already merged the original into 'next' via 995cb54b5b (Merge branch 'tb/reverse-midx' into next, 2021-07-20).

So we'd have to update it on top. I think we can just leave it be, though. There's nothing incorrect about using test_i18ngrep for now, and there are a ton of existing instances to handle if we choose to do a bulk cleanup. One more isn't a big deal.

-Peff
Previous: Taylor Blau
Message 4 of 4 in “multi-pack-index: fix potential segfault without sub-command”
  1. multi-pack-index: fix potential segfault without sub-commandTaylor Blau, Jul 19, 2021
  2. Jeff KingJul 21, 2021
  3. multi-pack-index: fix potential segfault without sub-commandTaylor Blau, Jul 21, 2021
  4. Jeff KingJul 23, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.