git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] bundle tests: modernize, fix missing coverage & test_cmp

From
Taylor Blau <me@ttaylorr.com>
Date
Jul 20, 2021, 17:18 UTC
Message-ID
<YPcFccdfhW1rvxaw@nand.local>
In-Reply-To
<cover-0.2-00000000000-20210720T115052Z-avarab@gmail.com>
On Tue, Jul 20, 2021 at 01:52:07PM +0200, Ævar Arnfjörð Bjarmason wrote:
> A trivial series to improve the bundle tests a bit. This is split off
> from some larger changes to "git bundle" I have cooking, where the
> "test_cmp" in 2/2 helped assert & catch regressions.

Thanks. Both patches looked good to me, and I left a couple of minor suggestions on the latter patch to potentially clean things up a little bit.

But please feel free to ignore them, and only pick them up if you feel they do improve the readability. Since I would be happy to see this picked up as-is, it has my:

    Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

Previous: Taylor BlauNext: Ævar Arnfjörð Bjarmason
Message 9 of 14 in “bundle tests: modernize, fix missing coverage & test_cmp”
  1. 0/2 bundle tests: modernize, fix missing coverage & test_cmpÆvar Arnfjörð Bjarmason, Jul 20, 2021
  2. 1/2 bundle tests: use ">file" not ": >file"Ævar Arnfjörð Bjarmason, Jul 20, 2021
  3. Junio C HamanoJul 20, 2021
  4. Felipe ContrerasJul 20, 2021
  5. 2/2 bundle tests: use test_cmp instead of grepÆvar Arnfjörð Bjarmason, Jul 20, 2021
  6. Taylor BlauJul 20, 2021
  7. Ævar Arnfjörð BjarmasonJul 21, 2021
  8. Taylor BlauJul 22, 2021
  9. Taylor BlauJul 20, 2021
  10. 0/2 bundle tests: modernize, fix missing coverage & test_cmpÆvar Arnfjörð Bjarmason, Jul 21, 2021
  11. 1/2 bundle tests: use ">file" not ": >file"Ævar Arnfjörð Bjarmason, Jul 21, 2021
  12. 2/2 bundle tests: use test_cmp instead of grepÆvar Arnfjörð Bjarmason, Jul 21, 2021
  13. Taylor BlauJul 22, 2021
  14. Taylor BlauJul 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.