git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-bitmap: clarify comment in filter_bitmap_exclude_type()

From
Jeff King <peff@peff.net>
Date
Jul 20, 2021, 21:02 UTC
Message-ID
<YPc54AdUqD6T31ad@coredump.intra.peff.net>
In-Reply-To
<0d52628985bf4f499e0d5622ea40cdf499e73ebe.1626812121.git.me@ttaylorr.com>
On Tue, Jul 20, 2021 at 04:16:22PM -0400, Taylor Blau wrote:
Show 16 quoted lines
> The code that eventually became filter_bitmap_exclude_type() was
> originally introduced in 4f3bd5606a (pack-bitmap: implement BLOB_NONE
> filtering, 2020-02-14) to accelerate BLOB_NONE filters with bitmaps.
> 
> In 856e12c18a (pack-bitmap.c: make object filtering functions generic,
> 2020-05-04), it became filter_bitmap_exclude_type(). But not all of the
> comments were updated to be agnostic to the provided type.
> 
> Remove the remaining comments which should have been updated in
> 856e12c18a to reflect the type-agnostic nature of the function.
> 
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
> ---
> Noticed while I was reading some code in this area to see if we had
> accelerated the relatively new type filters. This trivial fix hopefully
> shouldn't produce conflicts with other in-flight bitmap series.

Yep, this looks good. I wrote a near-identical patch while working on [1], but that topic got stalled on "how is this part of partial clones even supposed to work?". But there's no reason not to make this trivial fix in isolation.

-Peff
Previous: Taylor BlauNext: Taylor Blau
Message 2 of 4 in “pack-bitmap: clarify comment in filter_bitmap_exclude_type()”
  1. pack-bitmap: clarify comment in filter_bitmap_exclude_type()Taylor Blau, Jul 20, 2021
  2. Jeff KingJul 20, 2021
  3. Taylor BlauJul 20, 2021
  4. Jeff KingJul 20, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.