Re: [PATCH] pack-bitmap: clarify comment in filter_bitmap_exclude_type()
- From
Jeff King <peff@peff.net>
- Date
- Jul 20, 2021, 21:02 UTC
- Message-ID
- <YPc54AdUqD6T31ad@coredump.intra.peff.net>
- In-Reply-To
- <0d52628985bf4f499e0d5622ea40cdf499e73ebe.1626812121.git.me@ttaylorr.com>
On Tue, Jul 20, 2021 at 04:16:22PM -0400, Taylor Blau wrote:
Show 16 quoted lines
> The code that eventually became filter_bitmap_exclude_type() was > originally introduced in 4f3bd5606a (pack-bitmap: implement BLOB_NONE > filtering, 2020-02-14) to accelerate BLOB_NONE filters with bitmaps. > > In 856e12c18a (pack-bitmap.c: make object filtering functions generic, > 2020-05-04), it became filter_bitmap_exclude_type(). But not all of the > comments were updated to be agnostic to the provided type. > > Remove the remaining comments which should have been updated in > 856e12c18a to reflect the type-agnostic nature of the function. > > Signed-off-by: Taylor Blau <me@ttaylorr.com> > --- > Noticed while I was reading some code in this area to see if we had > accelerated the relatively new type filters. This trivial fix hopefully > shouldn't produce conflicts with other in-flight bitmap series.
Yep, this looks good. I wrote a near-identical patch while working on [1], but that topic got stalled on "how is this part of partial clones even supposed to work?". But there's no reason not to make this trivial fix in isolation.
-Peff