Re: [PATCH] Makefile: add and use the ".DELETE_ON_ERROR" flag

From: Jeff King <peff@peff.net>
Date: Jun 30, 2021, 02:23 UTC
Message-ID: <YNvVpxeYH4LKZZCm@coredump.intra.peff.net>
In-Reply-To: <875yxxgkav.fsf@evledraar.gmail.com>

On Tue, Jun 29, 2021 at 09:39:26AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 6 quoted lines

> > I do not see a point in complicating the build procedure to avoid
> > using it.
> 
> I'd really understand your and Jeff's concerns if I was proposing some
> really complex workaround, but it's just extending & making consistent
> the "mv" dance we already use for 1/2 our rules already.

Just to clarify my position: I'm not all that upset about adding more uses of "mv", as I agree it's not a lot of code (and in general I like making things atomic). Mostly I was trying to understand your use case, and whether we could be encouraging a more robust workflow there.

And that's what I was prodding at in the last email: what's the reason that doing it in a separate workdir doesn't work? I did find your answers compelling that it takes more disk space, and you have to compile everything twice (I do use ccache myself, but I agree that "oh, just install ccache" is not helpful advice in the general case).

-Peff