Re: [PATCH 0/3] Makefile: "make tags" fixes & cleanup

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 22, 2021, 15:16 UTC
Message-ID: <YNH+zsXDnRsT3uvZ@nand.local>
In-Reply-To: <cover-0.3-00000000000-20210622T141844Z-avarab@gmail.com>

On Tue, Jun 22, 2021 at 04:21:24PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 6 quoted lines

> A small series to fix the various "tags" targets, i.e. "make tags TAGS
> cscope". We'll now properly detect their dependencies, so we don't
> needlessly run them every time. I have this as part of my standard
> "make git" command, so doing nothing when we have nothing to do is
> preferrable, especially when my editor will eagerly reload the TAGS
> file every time it changes.

:-). Very nice.

> As noted in 3/3 this is better on top of my just-submitted
> .DELETE_ON_ERROR change[1], but will also work independently of that
> patch/series.

I took a look at this and [1], and I agree that 3/3 is probably better applied after [1], since it doesn't leave any gap between the existing behavior of ">$@+ && mv $@+ $@" and ">$@" with .DELETE_ON_ERROR.

But I don't feel strongly about the order in which the two are applied. Your 3/3 without [1] isn't wrong, it just leaves us the opportunity to permanently leave around a broken tags file permanently, whereas having [1] applied ahead of time means that the broken tags file is only visible racily.

I reviewed these patches carefully, and they look good to me. I'm delighted that `make tags` is no longer PHONY.

    Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor