git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t: use portable wrapper for readlink(1)

From
Jeff King <peff@peff.net>
Date
Jun 18, 2021, 19:48 UTC
Message-ID
<YMz4eFmwFuPv3Ke+@coredump.intra.peff.net>
In-Reply-To
<YMzwWxkQXjDT+mi+@camp.crustytoothpaste.net>
On Fri, Jun 18, 2021 at 07:13:31PM +0000, brian m. carlson wrote:
Show 10 quoted lines
> > This is a re-post that doesn't seem to have made it into "seen"; the
> > original[1] was buried in a thread, but Ævar reported there that it
> > fixes t3210 on his AIX build.
> >
> > [1] https://lore.kernel.org/git/YLk0Zm2J6VOA%2Flks@coredump.intra.peff.net/
> 
> In case I didn't say it up in the previous post, this looks fine to me.
> Using Perl here seems like a fine solution.  If we needed to in the
> future, we could add this to test-tool and use the real readlink(2), but
> we can hold off until we decide we need to.

Agreed on all counts (if we do want to drop perl from the test suite, there are a lot of these little one-liners that would need converting).

Thanks.
-Peff
Previous: brian m. carlsonNext: Junio C Hamano
Message 3 of 4 in “t: use portable wrapper for readlink(1)”
  1. t: use portable wrapper for readlink(1)Jeff King, Jun 18, 2021
  2. brian m. carlsonJun 18, 2021
  3. Jeff KingJun 18, 2021
  4. Junio C HamanoJun 19, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.