Re: [PATCH] doc: warn people against --max-pack-size

From: Jeff King <peff@peff.net>
Date: Jun 18, 2021, 15:18 UTC
Message-ID: <YMy5Nimj7F1r4Yn4@coredump.intra.peff.net>
In-Reply-To: <de7239bc-d68e-c9f5-1c97-87df24cfe7b1@iee.email>

On Fri, Jun 18, 2021 at 04:15:23PM +0100, Philip Oakley wrote:

Show 16 quoted lines

> > I'm not quite sure what you're asking. If you mean: should we tell
> > people that they can't use "4.9m" and should instead use "5017k"
> > instead, then I don't have a strong opinion.
> 
> Sorry, I should have included an example based on the patch
> 
> > +The minimum size allowed is limited to 1 MiB. The default is unlimited.
> > +Common unit suffixes of 'k', 'm', or 'g' are supported.
> 
> e.g.
> 
> +The default is unlimited. Common unit suffixes of 'k', 'm', or 'g' are
> +supported. The minimum size allowed is limited to 1 MiB (`1024k`). 
> 
> I swapped the sentence order to allow the scaled example of the minimum
> to be after the explanation of the suffixes

Ah, I see. I don't have a strong feeling either way if you want to prepare a patch.

-Peff