Re: Request feature: –no-submodule

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 3, 2021, 02:33 UTC
Message-ID: <YLg/dLqYFEqHZJUn@nand.local>
In-Reply-To: <xmqq8s3r7oma.fsf@gitster.g>

On Thu, Jun 03, 2021 at 09:55:57AM +0900, Junio C Hamano wrote:

Show 7 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
>
> > In all honesty, though this seems like a niche request for ls-files to
> > fulfill, ls-files already has quite the collection of options, so I
> > wouldn't be sad to see it learn how to do this, too.
>
> I would be somewhat sad for two reasons.

Mmm, that's a convincing set of reasons to think that this is a bad idea. (And I was sort of on the fence about it anyway by posting the whole thing as a short diff instead of a polished patch).

> I wonder if the "attr" magic of the pathspec, that allows you to
> choose paths based on the attributes you set on them, is what the
> original requestor missed.

Maybe... but relying on the attr magic for this particular case would force the requester to set that attribute on all submodules in their project, and constantly keep that in-sync with their .gitmodules. So, it certainly make it easier to handle a request like "I don't care about ls-files telling me about any submodule(s) except these ones", but perhaps at the expense of some extra bookkeeping.

I might be missing something, though.

Thanks, Taylor