Re: git feature request: git blame --ignore-cleanup/--ignore-trivial

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 2, 2021, 19:41 UTC
Message-ID: <YLfe+HXl4hkzs44b@nand.local>
In-Reply-To: <YLej6F24Emm7SX35@zeniv-ca.linux.org.uk>

On Wed, Jun 02, 2021 at 03:29:44PM +0000, Al Viro wrote:

Show 8 quoted lines

> > Any maybe the patterns associated to "cleanup" and "trivial" commits
> > should be something that can be configured through a git config
> > file.
>
> Just an observation: quite a few subtle bugs arise from mistakes in
> what should've been a trivial cleanup.  Hell, I've seen bugs coming
> from rebase of provably no-op patches - with commit message unchanged.
> So IME this is counterproductive...

Yes, I find excluding revisions from 'git blame' to be rarely useful, exactly for this reason.

You could probably use the '--ignore-revs-file' option of 'git blame' to exclude commits you consider trivial ahead of time. If you had an 'Is-trivial' trailer, I would probably do something like:

  $ git log --format='%H %(trailers:key=Is-trivial)' |
      grep "Is-trivial: true" | cut -d" " -f1 >exclude
  $ git blame --ignore-revs-file exclude ...

Thanks, Taylor