Re: [PATCH v4] help: colorize man pages

From: Jeff King <peff@peff.net>
Date: May 22, 2021, 09:55 UTC
Message-ID: <YKjU+/mGzWoqe88V@coredump.intra.peff.net>
In-Reply-To: <60a828cebd2f1_77e4f208b2@natae.notmuch>

On Fri, May 21, 2021 at 04:40:30PM -0500, Felipe Contreras wrote:

Show 11 quoted lines

> Jeff King wrote:
> > On Fri, May 21, 2021 at 01:01:35PM -0500, Felipe Contreras wrote:
> > 
> > > > I still don't understand what we gain by making this a Git feature,
> > > 
> > > What do we gain by making `git diff` output color?
> > 
> > Huh? Git is outputting the diff. Who else would output the color?
> 
> Do you think our users know or care which binary has the final
> connection to the tty?

Yes. If we are telling them that "git help git" is using "man", which we do, then I think they should expect it to behave like "man".

Moreover, I think that if they like colorized manpages, they'd probably want them when running "man" themselves.

-Peff