[PATCH 0/2] fix v2.32.0-rc0 bug with Negotiate / HTTP_NOAUTH

From: Jeff King <peff@peff.net>
Date: May 18, 2021, 06:26 UTC
Message-ID: <YKNeJ+NKUbD5ixA9@coredump.intra.peff.net>
In-Reply-To: <YKNVop80H8xSTCjz@coredump.intra.peff.net>

On Tue, May 18, 2021 at 01:50:27AM -0400, Jeff King wrote:

Show 6 quoted lines

> So perhaps somebody can come up with something clever, but I suspect we
> may need to just revert this for the v2.32 release, and re-break the
> case that 1b0d9545bb8 was trying to solve.
> 
> We probably should beef up the tests around http's credential-rejection,
> too, to catch this regression.

Here are some patches. The first one adds the tests, and I think is an obvious improvement.

The second one does the revert. I'd be quite happy if somebody wants to figure out how to fix it in a way that addresses the original problem, and then we can replace that. But in the meantime, I think it makes sense to prepare the revert, as we wouldn't want to release v2.32.0 with the bug.

  [1/2]: t5551: test http interaction with credential helpers
  [2/2]: Revert "remote-curl: fall back to basic auth if Negotiate fails"

 http.c                      | 15 +++++++-------
 t/t5551-http-fetch-smart.sh | 41 +++++++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+), 8 deletions(-)

-Peff