Re: SunCC doesn't compile v2.32.0-rc* anymore (was "Re: [PATCH 2/3] t/helper/test-bitmap.c: initial commit")

From: Taylor Blau <me@ttaylorr.com>
Date: May 26, 2021, 18:44 UTC
Message-ID: <YK6W+q1BhC1ZiB6H@nand.local>
In-Reply-To: <87h7ipmjkw.fsf@evledraar.gmail.com>

On Wed, May 26, 2021 at 08:30:49PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 18 quoted lines

>
> On Wed, Mar 31 2021, Taylor Blau wrote:
>
> > Add a new 'bitmap' test-tool which can be used to list the commits that
> > have received bitmaps.
> > [...]
> > @@ -0,0 +1,24 @@
> > +#include "test-tool.h"
> > +#include "cache.h"
> > +#include "pack-bitmap.h"
>
> Since this commit SunCC (on Solaris) refuses to compile git, a new bug
> in v2.32.0-rc*.
>
> It's because it can't find the oe_get_size_slow symbol, you include
> pack-bitmap.h, which in turn includes pack-objects.h. That file
> references oe_get_size_slow, but it's only defined in
> builtin/pack-objects.c.

I'm not sure I understand. pack-objects.h has a declaration of that method, but the implementation is in builtin/pack-objects.c. That should be fine, but I don't know about how SunCC works.

What needs to be changed here?

Thanks, Taylor