Re: [PATCH] Makefile: make PERL_DEFINES recursively expanded

From: Jeff King <peff@peff.net>
Date: May 12, 2021, 19:53 UTC
Message-ID: <YJwyJKxXJ5Oe+EYD@coredump.intra.peff.net>
In-Reply-To: <patch-1.1-92571a8cf7-20210512T094803Z-avarab@gmail.com>

On Wed, May 12, 2021 at 11:49:44AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 8 quoted lines

> Since 07d90eadb50 (Makefile: add Perl runtime prefix support,
> 2018-04-10) PERL_DEFINES has been a simply-expanded variable, let's
> make it recursively expanded instead.
> 
> This change doesn't matter for the correctness of the logic. Whether
> we used simply-expanded or recursively expanded didn't change what we
> wrote out in GIT-PERL-DEFINES, but being consistent with other rules
> makes this easier to understand.

Thanks for following up on this. I think it's worth doing.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.