Re: [PATCH 01/11] doc: allow the user to provide ASCIIDOC_EXTRA

From: Jeff King <peff@peff.net>
Date: May 15, 2021, 09:39 UTC
Message-ID: <YJ+WzATLCM8SW2GH@coredump.intra.peff.net>
In-Reply-To: <YJ+VGKUa0Kk3BRWQ@coredump.intra.peff.net>

On Sat, May 15, 2021 at 05:32:08AM -0400, Jeff King wrote:

Show 6 quoted lines

> On Fri, May 14, 2021 at 07:14:25AM -0500, Felipe Contreras wrote:
> 
> > Without `override` all additions will be ignored by make.
> 
> That's true of all of our Makefile variables. Is there a particular
> reason to give this one special treatment?

To go into further detail: usually we distinguish variables we use internally from user-facing ones, and include the latter in the former. I see a later patch wants to start passing ASCIIDOC_EXTRA on the command-line, and we'd use two variables for that.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.