Re: [PATCH v2 3/5] doc: remove unnecessary rm instances

From: Jeff King <peff@peff.net>
Date: May 15, 2021, 09:24 UTC
Message-ID: <YJ+TQiYVgocUBQRV@coredump.intra.peff.net>
In-Reply-To: <20210514115631.503276-4-felipe.contreras@gmail.com>

On Fri, May 14, 2021 at 06:56:29AM -0500, Felipe Contreras wrote:

Show 8 quoted lines

> Commits 50cff52f1a (When generating manpages, delete outdated targets
> first., 2007-08-02) and f9286765b2 (Documentation/Makefile: remove
> cmd-list.made before redirecting to it., 2007-08-06) created these rm
> instances for a very rare corner-case: building as root by mistake.
> 
> It's odd to have workarounds here, but nowhere else in the Makefile--
> which already fails in this stuation, starting from
> Documentation/technical/.

Aren't there tons more that you end up removing in the next patch? E.g.:

   doc.dep : $(docdep_prereqs) $(DOC_DEP_TXT) build-docdep.perl
  -       $(QUIET_GEN)$(RM) $@+ $@ && \
  -       $(PERL_PATH) ./build-docdep.perl >$@+ $(QUIET_STDERR) && \
  -       mv $@+ $@
  +       $(QUIET_GEN)$(PERL_PATH) ./build-docdep.perl >$@ $(QUIET_STDERR)

That does differ in that it removes $@+, too, but the premise is the same (we know that $@+ could not be a problem, as we're about to clobber it anyway).

I'm OK with getting rid of all of them, but it seems like it ought to be happening all in this patch.

(And in general the rest of the series looks OK to me).

-Peff