Re: What's cooking in git.git (Apr 2021, #05; Mon, 19)

From: Jeff King <peff@peff.net>
Date: Apr 23, 2021, 14:41 UTC
Message-ID: <YILciIL/WtNWdOPF@coredump.intra.peff.net>
In-Reply-To: <87mttt2hcu.fsf@evledraar.gmail.com>

On Tue, Apr 20, 2021 at 03:52:33PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 13 quoted lines

> > * ab/fsck-unexpected-type (2021-04-13) 6 commits
> >  - fsck: report invalid object type-path combinations
> >  - fsck: report invalid types recorded in objects
> >  - object-store.h: move read_loose_object() below 'struct object_info'
> >  - fsck: don't hard die on invalid object types
> >  - fsck tests: refactor one test to use a sub-repo
> >  - cache.h: move object functions to object-store.h
> >
> >  "git fsck" has been taught to report mismatch between expected and
> >  actual types of an object better.
> 
> Jeff King: *re-poke* per the mention the last WC: I.e. did you review
> this?

I hadn't, but I just did. I had some organizational nits to pick in the middle, but there's something really wrong with the cat-file changes in patch 5. I stopped there for now, because at least one of us is really confused. ;)

-Peff