Re: What's cooking in git.git (Apr 2021, #04; Thu, 15)

From: Jeff King <peff@peff.net>
Date: Apr 16, 2021, 03:04 UTC
Message-ID: <YHj+xvav1I0UGAe0@coredump.intra.peff.net>
In-Reply-To: <YHj9mUzs+jlgNuVE@coredump.intra.peff.net>

On Thu, Apr 15, 2021 at 10:59:37PM -0400, Jeff King wrote:

Show 25 quoted lines

> On Thu, Apr 15, 2021 at 05:04:37PM -0700, Junio C Hamano wrote:
> 
> > * ps/config-global-override (2021-04-13) 3 commits
> >   (merged to 'next' on 2021-04-15 at 60a58d74ab)
> >  + config: allow overriding of global and system configuration
> >  + config: unify code paths to get global config paths
> >  + config: rename `git_etc_config()`
> > 
> >  Replace GIT_CONFIG_NOSYSTEM mechanism to decline from reading the
> >  system-wide configuration file with GIT_CONFIG_SYSTEM that lets
> >  users specify from which file to read the system-wide configuration
> >  (setting it to an empty file would essentially be the same as
> >  setting NOSYSTEM), and introduce GIT_CONFIG_GLOBAL to override the
> >  per-user configuration in $HOME/.gitconfig.
> > 
> >  Will merge to 'master'.
> 
> Looks like this fails CI on the Windows VS build. I get:
> 
>   ++ env GIT_CONFIG_GLOBAL=does-not-exist GIT_CONFIG_SYSTEM=/dev/null git config --global --list
>   fatal: unable to access 'nul': Invalid argument
> 
> from t1300.181. I thought we had some magic to make /dev/null work there
> (or maybe this _is_ the magic kicking in, since it is looking for the
> Windows-ish nul, but it is not working for some reason).

Ah, indeed. mingw_open() has:

          if (filename && !strcmp(filename, "/dev/null"))
                wcscpy(wfilename, L"nul");

which is clearly kicking in. But I have no idea why that might not work here. We may need some assistance from Windows folks (cc'd).

-Peff