Re: [PATCH 1/2] test-lib: allow test snippets as here-docs

From: Jeff King <peff@peff.net>
Date: Apr 9, 2021, 22:30 UTC
Message-ID: <YHDVhmveVlkHPBNb@coredump.intra.peff.net>
In-Reply-To: <YHDVAxxKDzfTlq3h@coredump.intra.peff.net>

On Fri, Apr 09, 2021 at 06:28:19PM -0400, Jeff King wrote:

Show 7 quoted lines

> +   If <script> is `-` (a single dash), then the script to run is read
> +   from stdin. This lets you more easily use single quotes within the
> +   script by using a here-doc. For example:
> +
> +        test_expect_success 'output contains expected string' <<-\EOT
> +	        grep "this string has 'quotes' in it" output
> +	EOT

Whoops, this should have an extra "-", of course (I got this wrong in the cover letter, too). I.e.:

  test_expect_success 'whatever' - <<\EOT
     ...
  EOT

It would be nice to drop it, but then:

  test_expect_success PREREQ 'whatever' <<\EOT

becomes ambiguous (and I don't think there is a portable and reliable way to decide that our input is coming from a here-doc versus the original stdin).

-Peff